Stream at 1920x1080

[hugomc92]

Could be possible to add support for 1080p streaming?

There is currently a fork that enable it (this repo) but it's outdated and can't stablish connection (RTSP handshake error) which is fixed in this repo.

Thanks in advance

[d3m3vilurr]

hello. 1080p & RTSP handshake problem are different parts.

first, current codeset detect correct resolutions of the vita https://github.com/xyzz/vita-moonlight/blob/vita/src/gui/ui_settings.c#L486-L490 this codeset already contains 1920x1080.

second, afaik RTSP handshake problem is related sscanf of the newlib https://github.com/xyzz/vita-moonlight/blob/vita/libgamestream/client.c#L563

current vita newlib doesn't support %2hhx that this is not the part of the posix standard. so i'm considering to add the patch into vita newlib or replace sscanf codeset to another way.

in this reason, I wouldn't merge pr #220 ...

[hugomc92]

Hello, I know 1080p and RSTP handshake are diferent things.

I wanted to say that in that repo vpk there is selectable option for 1920x1080 in resolution but when it tries to connect it gives RSTP handshake error and in your vpk there isn't selectable option for 1080 (at least for my PS Vita Slim, maybe I am missing something) and it already connect to PC without any problems.

Maybe the thing is not to merge the pull request, maybe there is another thing could be done to get 1920x1080 selectable resolution if you can or maybe just tell me if there's something I can do to get that resolution as an option.

Thank you very much in advance!

[Fewnity]

second, afaik RTSP handshake problem is related sscanf of the newlib https://github.com/xyzz/vita-moonlight/blob/vita/libgamestream/client.c#L563

current vita newlib doesn't support %2hhx that this is not the part of the posix standard. so i'm considering to add the patch into vita newlib or replace sscanf codeset to another way.

Hello! Do you think you can fix this? Is it an easy patch to do?