Open jmsull opened 3 years ago
@jmsull, I can fix this! I wrote the current RECFAST to replicate the original version as closely as possible, in a way that is not very flexible. This is also related to fixing the differentiability of the RECFAST implementation. The steps would be
This all sounds good! One quick thing to mention is that I bumped up Nz to 100000 (this is also the default value in CLASS)
If I run the following
when I get to the last line I get the following error:
"ERROR: BoundsError: attempt to access 141-element scale(interpolate(OffsetArray(::Array{Float64,1}, 0:142), BSpline(Cubic(Line(OnGrid())))), (-15.0:0.1:-1.0,)) with element type Float64 at index [-0.9980221350275645]"
which is coming from around here since zfinal=0.0 appears hardcoded.
Can be persuaded otherwise but it would be nice if we allowed arbitrary final redshift for the perturbations? I will continue using 0 for now since this is not a priority, but this is something to maybe come back to later.