xzackli / OscillatoryIntegralsODE.jl

MIT License
5 stars 1 forks source link

Several Warnings due to new versions of Julia #5

Closed arthurmloureiro closed 1 year ago

arthurmloureiro commented 1 year ago

Hi @xzackli ! This looks like an excellent package and a perfect solution to solve these painfully slow to integrate functions.

However, while running the example, I get countless warnings from Julia due to compatibility issues. Are there plans to update this package?

Ex:

Screenshot 2023-03-02 at 10 17 47

I posted a screenshot because there are hundreds of lines of warnings, the warnings persist anytime the levintegrate function is called.

xzackli commented 1 year ago

Hey @arthurmloureiro, I'm happy to update this package. It was somewhat of a proof of concept, but Levin is more robust in some ways compared to other methods.

  1. In the long term there should probably be a non-limber source function integration package in the Julia ecosystem, and this code would be in there along with FFTLog-based approaches.
  2. There are more modern Levin variants that would be significantly faster, particularly at high accuracy. Let me know if you find this class of methods useful/interesting.
xzackli commented 1 year ago

The version now on main tagged as 0.1.1 should not yield any errors (tested on 1.9beta4).

arthurmloureiro commented 1 year ago

Hi @xzackli !

First: Thank you so much! I am still too new to Julia to be able to fix this and submit an MR.

A FFTLog-based approach is quite interesting! There's this python package here by @ntessore: https://fftl.readthedocs.io/en/latest/index.html which could be quite helpful :)