Cache is incorrectly invalidated on changes in the current directory

expipiplus1 commented 4 years ago

Take for example the following derivation

{ pkgs ? import <nixpkgs> { } }:

pkgs.stdenv.mkDerivation {
  name = "foo";
  src = ./foo;
}

To reproduce:

Put the above derivation in default.nix in an otherwise empty directory
Make a directory called foo
Run cached-nix-shell
Run cached-nix-shell again and observe that the cache is working
Run touch a
Run cached-nix-shell and observe that although a is not in the source directory foo the cache is still invalidated
- The message is cached-nix-shell: "/home/j/projects/bugs/cached-nix-shell": expected "bc9d52f13592f11e33761497c538180e", got "cad355673ba8cdb0ef003c8515174e77"

expipiplus1 commented 4 years ago

This doesn't happen if cached-nix-shell is given the argument default.nix explicitly.

expipiplus1 commented 4 years ago

I guess this is happening because nix-shell is checking the current directory for the presence of default.nix or shell.nix

expipiplus1 commented 4 years ago

Perhaps the title isn't fair, it's correctly invalidated because indeed the contents of the directory have changed, however it would be possible to be more specific here.

expipiplus1 commented 4 years ago

How embarrassing, I seem to be unable to reproduce this, sorry.

xzfc / cached-nix-shell

Cache is incorrectly invalidated on changes in the current directory #10