search

xzhang395 / Stalk-Market

find the best turnip price
Apache License 2.0
2 stars 2 forks source link

Timezone should be taken into account #17

Closed j-zhao closed 4 years ago

j-zhao commented 4 years ago

Data is only relevant if timezone is taken into account, otherwise there will be price discrepancies. Each price should have its own TTL

chiapet92 commented 4 years ago

Hi @j-zhao , thanks for cutting an issue.

Are you seeing this as an actual bug or just an FYI? The TTL has already been implemented in a previous fix.

j-zhao commented 4 years ago

Feature request for timezones

chiapet92 commented 4 years ago

What exactly do you want to see regarding timezones? The application already handles:

1) local time of the user and properly sets the expiration time based on that value. 2) calculation of the expiration time based on the expiration of the highest score in ISO time

If the application doesn't handle anything specifically, please detail out that case.

j-zhao commented 4 years ago

I see what you mean, this wasn't obvious, so a row is only displayed if it's not expired? Feel free to close the issue.

On Tue, Apr 7, 2020, 9:14 AM Mark Qi notifications@github.com wrote:

What exactly do you want to see regarding timezones? The application already handles:

  1. local time of the user and properly sets the expiration time based on that value.
  2. calculation of the expiration time based on the expiration of the highest score in ISO time

If the application doesn't handle anything specifically, please detail out that case.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_xzhang395_Stalk-2DMarket_issues_17-23issuecomment-2D610480820&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=2cUwSphtpIP-_NH6IeX4Jg&m=peuebdYtVsHlLzjq3zlKeMbjmvqSAiw5Vc21lI3mrXI&s=NDivP-XL9yx_cgBzRPlktRpppVWp4agecZaBd-NZ_6s&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABQED32SGKQXXBCFVG3TSSLRLNGN7ANCNFSM4MCWR6WA&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=2cUwSphtpIP-_NH6IeX4Jg&m=peuebdYtVsHlLzjq3zlKeMbjmvqSAiw5Vc21lI3mrXI&s=T6dDfFK5yKDMQPc6VkoAQp-Iz5s3FdsWYgI-F2ZJ3Rw&e= .

chiapet92 commented 4 years ago

The current code performs a filter on retrieval, so none of the expired entries are ever displayed.

https://github.com/xzhang395/Stalk-Market/blob/8f8eb9e08fc7acd50e8452600d4846f148b22dde/src/containers/App.js#L36-L38

Closing issue.

chiapet92 commented 4 years ago

Completed in https://github.com/xzhang395/Stalk-Market/issues/5