search

xzos / PyZDDE

Zemax/ OpticStudio Extension using Python
MIT License
154 stars 64 forks source link

Added some information on the PSFinfo side in zGetPsf #58

Closed B2015 closed 8 years ago

B2015 commented 8 years ago

Hi Indranil, I finally was able to find out how github work and commit the changes you suggested for the update of PSFinfo. I made a small correction to a typo so that the function works nicely.

cheers & thanks again for your help

Ben

indranilsinharoy commented 8 years ago

Hi Ben, Thank you very much, it looks good. I will merge your branch into the main branch ASAP (probably by today or tomorrow). By the way, what typo did you fix? I couldn't find it during my quick check, it would be very kind of you if you could point it out.

Thanks again, Regards, Indranil.

B2015 commented 8 years ago

Hello Indranil,

I'm not sure whether the typo is yours or if some fancy trick happened when you copied the code to the github discussion but there was this line:

ctr_ref_x, ctr_ref_y = [float(i) for i in _re.findallr'-?\d.\d{4,10}[Ee][-+]\d{3}', ctr_ref_line)]

where you can see the part "in _re.findallr'-?\d\" that should instead read as "in _re.findall('-?\d\" I'm not sure why the parenthesis has been replaced by a 'r' though.

Cheers,

Ben

indranilsinharoy commented 8 years ago

Hi Ben,

Thanks. Yes, I had made that mistake while typing (obvioiusly I didn't check / execute the code :-) .
Thanks. I will merging the changes now.