Closed Kovarthanan-murugan closed 10 months ago
000fe2f4d50668f2eb2ed46502bd6b1f47d21d54
Do you create cache objects every time a building is cached, but don't store them anywhere? And don't use List, Anuken/Arc has a Seq class which is a bit faster
000fe2f4d50668f2eb2ed46502bd6b1f47d21d54
And why are there two spaces? ;-;
6bce30ac3c19572a38ebd357e79658cecd0fff1d
Why did you copy the send method into AdminsTools?
e21c0fd5627fc3a80867c59d63b5a754ee1fecdc
The first two lines say mouseX - screenWidth
and mouseY - screenHeight
, but you only have the first of the two, so the camera will only move diagonally from bottom left to top right ;-;
831106e0485331bcd14f03224b0e313be53fc4d7 is good
I see that you really tried, and I really appreciate it, there are not many such people now, but 3 out of 6 commits completely breaks everything, so at the moment I cannot accept the changes.
The first two lines say
mouseX - screenWidth
andmouseY - screenHeight
, but you only have the first of the two, so the camera will only move diagonally from bottom left to top right ;-;
I appreciate you taking the time to review my modifications and provided feedback for my changes. I have rectified the error you pointed out.
b50495d
Why did you copy the send method into AdminsTools?
It should not be there, I added it by mistake, fixed it in 0548fbc
And why are there two spaces? ;-;
Fixed it in 0548fbc
In class ModedDesktopInput In Update method Refactored the complex conditional
In Class ModedDesktopInput In Update method Introduced Explaining Variable In Class ModedGlyphLayout In setText method Introduced Explaining Variable
In Class ModedMobileInput In Update method Refactored the complex update method
In Class Darkdusty and SlashJs have a duplicate method so pull up the method to class AdminsTools. and override the same method in the internal class which has a different implementation compared. to other two classes which implement the same class.
Refactored Cyclic Dependency Classes FlipButton and HudFragments were implemented with cyclic dependency. Made changes to refactor the cyclic dependency.
Refactored Conditional Statement with polymorphism In BuildsCache class refactored the cache method so new conditions can be added.