xzxADIxzx / Scheme-Size

No longer just increases the schema size
169 stars 22 forks source link

Refactored #44

Closed Kovarthanan-murugan closed 10 months ago

Kovarthanan-murugan commented 1 year ago
  1. In class ModedDesktopInput In Update method Refactored the complex conditional

  2. In Class ModedDesktopInput In Update method Introduced Explaining Variable In Class ModedGlyphLayout In setText method Introduced Explaining Variable

  3. In Class ModedMobileInput In Update method Refactored the complex update method

  4. In Class Darkdusty and SlashJs have a duplicate method so pull up the method to class AdminsTools. and override the same method in the internal class which has a different implementation compared. to other two classes which implement the same class.

  5. Refactored Cyclic Dependency Classes FlipButton and HudFragments were implemented with cyclic dependency. Made changes to refactor the cyclic dependency.

  6. Refactored Conditional Statement with polymorphism In BuildsCache class refactored the cache method so new conditions can be added.

xzxADIxzx commented 1 year ago

000fe2f4d50668f2eb2ed46502bd6b1f47d21d54 image

Do you create cache objects every time a building is cached, but don't store them anywhere? And don't use List, Anuken/Arc has a Seq class which is a bit faster

xzxADIxzx commented 1 year ago

000fe2f4d50668f2eb2ed46502bd6b1f47d21d54 image

And why are there two spaces? ;-;

xzxADIxzx commented 1 year ago

6bce30ac3c19572a38ebd357e79658cecd0fff1d image

Why did you copy the send method into AdminsTools?

xzxADIxzx commented 1 year ago

e21c0fd5627fc3a80867c59d63b5a754ee1fecdc image

The first two lines say mouseX - screenWidth and mouseY - screenHeight, but you only have the first of the two, so the camera will only move diagonally from bottom left to top right ;-;

xzxADIxzx commented 1 year ago

831106e0485331bcd14f03224b0e313be53fc4d7 is good

xzxADIxzx commented 1 year ago

I see that you really tried, and I really appreciate it, there are not many such people now, but 3 out of 6 commits completely breaks everything, so at the moment I cannot accept the changes.

Kovarthanan-murugan commented 1 year ago

e21c0fd image

The first two lines say mouseX - screenWidth and mouseY - screenHeight, but you only have the first of the two, so the camera will only move diagonally from bottom left to top right ;-;

I appreciate you taking the time to review my modifications and provided feedback for my changes. I have rectified the error you pointed out.

b50495d image

Kovarthanan-murugan commented 1 year ago

6bce30a image

Why did you copy the send method into AdminsTools?

It should not be there, I added it by mistake, fixed it in 0548fbc

Kovarthanan-murugan commented 1 year ago

000fe2f image

And why are there two spaces? ;-;

Fixed it in 0548fbc