Bug/mp3 issues diy - Githubissues

y-brehm / waveAlign

Python repo for audio loudness matching in order to end the loudness war between DJs.

3 stars 0 forks source link

Bug/mp3 issues diy #50

Closed SimonZimmer closed 3 weeks ago

SimonZimmer commented 3 weeks ago

Fix the mp3 synchronisation issue by delegating mp3 processing to the new mp3processor C executable. While I took care to reduce the original code to its absolute essentials, it's still too much refactoring work to get it done in time. (It's probably also better if we share some work so we'll be sharing the knowledge in the future)

So I made a new issue for the refactoring work: https://github.com/y-brehm/waveAlign/issues/49

Additionally:

add CmakeLists.txt for cross-platform compilation
add C executable compilation to gh-workflow
add windows steps to gh-workflow
refactor python tests for cross-platform compatibility
remove m4a support
add mac/windows command line argument parser for mp3processor

SimonZimmer commented 3 weeks ago

Everything in main.c is subject to the refactoring, so if you have any comments for this specific file that don't break the current functionality but are related to clean code/architecture, pls add them as a comment to https://github.com/y-brehm/waveAlign/issues/49.