y-crdt / y-octo

CRDT implementation which is compatible with https://github.com/yjs/yjs
https://octobase.pro/
Other
187 stars 5 forks source link

chore: apply clippy suggestions #37

Closed forehalo closed 8 months ago

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (48bdeb2) 78.60% compared to head (62cd05a) 79.49%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== + Coverage 78.60% 79.49% +0.89% ========================================== Files 50 49 -1 Lines 7659 7380 -279 ========================================== - Hits 6020 5867 -153 + Misses 1639 1513 -126 ``` | [Flag](https://app.codecov.io/gh/y-crdt/y-octo/pull/37/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [node-binding-test](https://app.codecov.io/gh/y-crdt/y-octo/pull/37/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 8 months ago

Benchmark for Linux

Click to view benchmark | Test | Base | PR | % | | --- | --- | --- | --- | | codec/jwst decode var_int (32 bit) | 213.0±0.68µs | 213.0±0.68µs | -0.00% | | codec/jwst decode var_uint (32 bit) | 178.3±1.16µs | 178.6±2.77µs | +0.17% | | codec/jwst decode var_uint (64 bit) | 180.5±1.55µs | 181.8±8.28µs | **+0.72%** | | codec/jwst encode var_int (32 bit) | 303.3±5.37µs | 302.3±1.16µs | -0.33% | | codec/jwst encode var_uint (32 bit) | 255.6±10.54µs | 253.1±3.46µs | -0.98% | | codec/jwst encode var_uint (64 bit) | 251.5±3.63µs | 251.7±3.09µs | +0.08% | | codec/lib0 decode var_int (64 bit) | 187.3±2.99µs | 186.0±2.19µs | -0.69% | | codec/lib0 decode var_uint (32 bit) | 154.5±3.78µs | 154.2±3.50µs | -0.19% | | codec/lib0 decode var_uint (64 bit) | 160.2±2.63µs | 153.3±2.68µs | **-4.31%** | | codec/lib0 encode var_int (64 bit) | 384.2±1.30µs | 391.9±1.32µs | **+2.00%** | | codec/lib0 encode var_uint (32 bit) | 373.3±3.87µs | 373.2±1.18µs | -0.03% | | codec/lib0 encode var_uint (64 bit) | 373.5±2.15µs | 373.3±1.24µs | -0.05% | | ops/array/jwst/insert | 105.4±0.57µs | 105.7±0.34µs | **+0.28%** | | ops/array/jwst/insert range | 156.6±0.66µs | 156.2±0.72µs | **-0.26%** | | ops/array/jwst/remove | 62.3±0.10µs | 62.1±1.23µs | **-0.32%** | | ops/array/yrs/insert | 57.5±0.50µs | 58.5±0.75µs | **+1.74%** | | ops/array/yrs/insert range | 74.8±2.14µs | 75.1±1.04µs | +0.40% | | ops/array/yrs/remove | 63.1±1.72µs | 65.6±0.54µs | **+3.96%** | | ops/map/jwst/get | 208.2±1.28ns | 208.4±2.02ns | +0.10% | | ops/map/jwst/insert | 2.8±0.04µs | 3.0±0.01µs | **+7.14%** | | ops/map/jwst/remove | 4.2±0.10µs | 4.4±0.03µs | **+4.76%** | | ops/map/yrs/get | 258.4±1.07ns | 260.3±2.28ns | **+0.74%** | | ops/map/yrs/insert | 3.9±0.07µs | 3.9±0.02µs | -0.00% | | ops/map/yrs/remove | 5.1±0.09µs | 5.1±0.03µs | -0.00% | | ops/text/jwst/insert | 68.8±0.35µs | 67.9±1.30µs | **-1.31%** | | ops/text/jwst/remove | 1418.2±10.80ns | 1416.8±17.01ns | -0.10% | | ops/text/yrs/insert | 27.3±0.09µs | 26.8±0.14µs | **-1.83%** | | ops/text/yrs/remove | 1770.6±11.51ns | 1733.7±11.78ns | **-2.08%** | | update/parse with jwst/basic.bin | 38.6±0.56µs | 39.7±0.23µs | **+2.85%** | | update/parse with jwst/database.bin | 29.6±0.11µs | 30.6±0.20µs | **+3.38%** | | update/parse with jwst/large.bin | 3.3±0.05ms | 3.3±0.03ms | -0.00% | | update/parse with jwst/with-subdoc.bin | 4.7±0.04µs | 5.0±0.16µs | **+6.38%** | | update/parse with yrs/basic.bin | 30.3±0.15µs | 31.1±0.36µs | **+2.64%** | | update/parse with yrs/database.bin | 23.2±0.43µs | 23.9±0.12µs | **+3.02%** | | update/parse with yrs/large.bin | 2.4±0.02ms | 2.4±0.01ms | -0.00% | | update/parse with yrs/with-subdoc.bin | 4.6±0.03µs | 4.1±0.02µs | **-10.87%** |

Benchmark for Windows

Click to view benchmark | Test | Base | PR | % | | --- | --- | --- | --- | | codec/jwst decode var_int (32 bit) | 212.7±0.90µs | 223.0±5.03µs | **+4.84%** | | codec/jwst decode var_uint (32 bit) | 178.8±2.70µs | 186.3±3.95µs | **+4.19%** | | codec/jwst decode var_uint (64 bit) | 195.3±3.62µs | 196.0±5.35µs | +0.36% | | codec/jwst encode var_int (32 bit) | 304.5±3.84µs | 314.2±6.83µs | **+3.19%** | | codec/jwst encode var_uint (32 bit) | 263.9±2.48µs | 267.4±6.07µs | **+1.33%** | | codec/jwst encode var_uint (64 bit) | 258.2±3.14µs | 266.1±6.16µs | **+3.06%** | | codec/lib0 decode var_int (64 bit) | 189.8±7.17µs | 188.9±5.99µs | -0.47% | | codec/lib0 decode var_uint (32 bit) | 159.9±9.97µs | 153.2±0.73µs | **-4.19%** | | codec/lib0 decode var_uint (64 bit) | 156.5±7.41µs | 158.4±7.00µs | +1.21% | | codec/lib0 encode var_int (64 bit) | 385.5±7.21µs | 386.6±2.96µs | +0.29% | | codec/lib0 encode var_uint (32 bit) | 373.4±1.08µs | 374.2±1.04µs | +0.21% | | codec/lib0 encode var_uint (64 bit) | 373.7±1.46µs | 374.1±2.37µs | +0.11% | | ops/array/jwst/insert | 122.8±0.72µs | 122.5±0.57µs | **-0.24%** | | ops/array/jwst/insert range | 185.6±5.48µs | 181.7±0.74µs | **-2.10%** | | ops/array/jwst/remove | 66.8±0.29µs | 65.6±0.40µs | **-1.80%** | | ops/array/yrs/insert | 73.5±0.25µs | 72.1±0.37µs | **-1.90%** | | ops/array/yrs/insert range | 99.2±0.85µs | 99.3±0.85µs | **+0.10%** | | ops/array/yrs/remove | 103.1±0.29µs | 108.6±2.75µs | **+5.33%** | | ops/map/jwst/get | 260.4±3.22ns | 259.8±2.88ns | -0.23% | | ops/map/jwst/insert | 4.7±0.02µs | 4.6±0.02µs | **-2.13%** | | ops/map/jwst/remove | 6.9±0.03µs | 6.8±0.04µs | **-1.45%** | | ops/map/yrs/get | 271.9±4.77ns | 270.5±4.80ns | -0.51% | | ops/map/yrs/insert | 5.8±0.11µs | 5.7±0.03µs | **-1.72%** | | ops/map/yrs/remove | 6.9±0.05µs | 7.4±0.06µs | **+7.25%** | | ops/text/jwst/insert | 84.9±0.51µs | 83.1±1.04µs | **-2.12%** | | ops/text/jwst/remove | 2.2±0.01µs | 2.1±0.01µs | **-4.55%** | | ops/text/yrs/insert | 33.4±0.12µs | 33.7±0.22µs | **+0.90%** | | ops/text/yrs/remove | 2.5±0.01µs | 2.5±0.02µs | -0.00% | | update/parse with jwst/basic.bin | 55.6±0.45µs | 55.1±0.49µs | **-0.90%** | | update/parse with jwst/database.bin | 43.1±0.20µs | 44.4±0.21µs | **+3.02%** | | update/parse with jwst/large.bin | 2.8±0.15ms | 2.6±0.07ms | **-7.14%** | | update/parse with jwst/with-subdoc.bin | 8.3±0.04µs | 7.7±0.06µs | **-7.23%** | | update/parse with yrs/basic.bin | 43.6±0.21µs | 44.8±0.66µs | **+2.75%** | | update/parse with yrs/database.bin | 35.1±0.15µs | 34.2±0.14µs | **-2.56%** | | update/parse with yrs/large.bin | 2.2±0.09ms | 2.1±0.08ms | **-4.55%** | | update/parse with yrs/with-subdoc.bin | 7.3±0.05µs | 6.9±0.04µs | **-5.48%** |