search

y-crdt / ydotnet

.NET bindings for yrs.
MIT License
35 stars 9 forks source link

Windows binary produced via cross-compilation consumes all system memory. #18

Closed goldsam closed 1 year ago

goldsam commented 1 year ago

@LSViana I'm seeing memory consumption grow without bound for some of the map-related tests (InsertMap for example) on windows x64. Could you take a look at my github workflow. I'm current doing a cross-compilation when maybe building on windows might be the best approach.

I'm also patching the yffi/Cargo.toml to produce a dynamic library. What was your approach to building your local binary assets?

goldsam commented 1 year ago

This is cleared up by #19 which references custom yrs build

LSViana commented 1 year ago

@goldsam Just to give you some extra details for your mentions here:

I'm seeing memory consumption grow without bound for some of the map-related tests (InsertMap for example) on windows x64.

It's possible that there are some memory leaks in some operations, I have plans to check these once I'm done creating all bindings.

I'm also patching the yffi/Cargo.toml to produce a dynamic library.

Yes, that's what I'm doing currently as well. However, I'll look into the Cargo CLI options later to verify if it's possible to specify the crate-type through the commands so the main repository doesn't have to change.

But this, just like the issue mentioned above, will be focused only after the bindings are done.