search

y-crdt / ydotnet

.NET bindings for yrs.
MIT License
29 stars 9 forks source link

New write #90

Closed SebastianStehle closed 3 months ago

vdurante commented 4 months ago

@SebastianStehle it is working quite well in my experience. Amazing job. Don't forget to merge my PR into yours before merging this one.

SebastianStehle commented 4 months ago

I have commented a single line in your PR ;)

vdurante commented 4 months ago

@SebastianStehle I believe you didn't submit the review because there is no comments there

japsasuncion commented 3 months ago

Hi, Im uncertain if this is the appropriate channel but I'd like to ask if you could also test this change with tldraw.

The issue I'm having is that it does not load the persisted data for tldraw. I'm not sure if there's something wrong with the persisted data or the way it gets loaded or perhaps tldaw's data is much complex.

I do have a demo based off of this branch.

Also, not sure if it matters but it works on y-websocket.

TY 🙏

https://github.com/tldraw/tldraw-yjs-example

SebastianStehle commented 3 months ago

Could you provide a PR for that? We are having a demo page for several cases: https://github.com/y-crdt/ydotnet/tree/main/Demo/Client

Perhaps...

  1. Add react-router and make one page per test case.
  2. Add a new page for tldraw
SebastianStehle commented 3 months ago

@japsasuncion What do you think?

japsasuncion commented 3 months ago

@SebastianStehle submitted pr for tldraw https://github.com/y-crdt/ydotnet/pull/95

SebastianStehle commented 3 months ago

I cannot reproduce the problem...

japsasuncion commented 3 months ago

@SebastianStehle Thanks for checking. The way I test it is by closing the tabs and shutting down both client and server, then starting again. I'm also testing with Win32

SebastianStehle commented 3 months ago

I have done the same.

japsasuncion commented 3 months ago

Thanks! Looking forward for this to get merged. 🙏

twaddell commented 3 months ago

Just wanted to add that this PR has fixed a similar issue in a project I'm working on. Where bad document data was being sent to the storage. Thank you.