search

y-crdt / ypy-websocket

WebSocket Connector for Ypy
https://davidbrochart.github.io/ypy-websocket
MIT License
42 stars 21 forks source link

ASGI compatible server #37

Closed rmorshea closed 1 year ago

rmorshea commented 1 year ago

This would be more useful if the server were compatible with the ASGI spec. If it were, ypy-websocket could immediately be used in conjunction with popular web servers like Starlette, FastAPI, and Sanic.

davidbrochart commented 1 year ago

I agree, on the other hand ypy-websocket is used in Jupyter Server, which still uses Tornado, but there could probably be an adapter to make it work there. Do you want to take a stab at it? Your contribution would be greatly appreciated!

rmorshea commented 1 year ago

It would probably be some time before I get to it, but yes, when I get around to https://github.com/idom-team/idom/issues/826 I'd start work on this.

linspw commented 1 year ago

Hello everything is fine? This ASGI support would help a lot, I'm trying to use this lib somehow in conjunction with django channels. If it had the implementation in ASGI it would help a lot.

I would like to contribute, but I have no idea how to create an adapter in this sense.

davidbrochart commented 1 year ago

Hi @linspw, I've not looked at it yet, but feel free to contribute. Maybe @rmorshea has ideas?

rmorshea commented 1 year ago

I don't think I'm going to get to this any time soon.

davidbrochart commented 1 year ago

I'm not very familiar with ASGI, does anyone know if this would have to be implemented from scratch or if it would be better to use e.g. Starlette?

davidbrochart commented 1 year ago

I started this work in #75.