Closed davidbrochart closed 1 year ago
Also, this is probably fine with an SQLite backend, but for a file backend it would likely require some locking mechanism to prevent accessing the file concurrently.
Can the lower level APIs have a method/function to pass in a logger?
Can the lower level APIs have a method/function to pass in a logger?
You mean that we would adhere to the Jupyter logger API? With logger.info()
, logger.debug()
, etc.
OK let's use the standard Python logging system API, which I think the Jupyter logging system uses.
OK let's use the standard Python logging system API, which I think the Jupyter logging system uses.
Yes this is what is used by Jupyter.
Thanks for the review @fcollonval.
@ellisonbg It would be interesting to test this change and see if it solves the issue you mentioned about performances on NFS. The problem I see with that, and I think you also talked about it, is that if we let the Y store be out-of-sync, then that will likely cause other issues, for instance if a user connects in the middle of a session - they will probably be out of sync too, and I don't know how it will behave.