search

y-crdt / yswift

Swift language bindings to Y-CRDT
https://y-crdt.github.io/yswift/documentation/yswift/
Other
68 stars 6 forks source link

GitHub CI #16

Closed heckj closed 1 year ago

heckj commented 1 year ago

Verified all the moving parts of this update - which adds continuous integration using Xcode 14 on GitHub Actions run on macOS 12 (Monterey) - on a local branch.

@dmonad could I request you to pop in to the settings for this repository and enable CI build actions? That's something I had to enable on my local fork of the repository in order to allow the workflow/action defined here to run.

heckj commented 1 year ago

@nugmanoff When I was working on updating the build-xcframework.sh script, I overstepped and broke a bunch of stuff, so I stepped back and thought it might be best to enable CI to double-check my work going forward. This PR (on which I'd love your review) is from that effort. It's my first real effort doing anything CI related with either Rust or using tuist, so if there's something I'm doing backwards or obviously wrong, I'd love to know!

heckj commented 1 year ago

You can see the the action logs in https://github.com/heckj/y-uniffi/pull/1, which is a parallel PR I made to this one to work this out before permissions were enabled: https://github.com/heckj/y-uniffi/actions/runs/4048620493/jobs/6964088594

heckj commented 1 year ago

The conflicts can be resolved with a rebase I think, but I think you're generally correct about the generated code not needing to strictly be in source control, so we could remove it and go from there. I'll aim to just rebase this for now to resolve the conflicts, and we can pull yniffi.swift from the source base in a subsequent PR if that's good with you