search

y-flat / yfc

The best (because it's the only) compiler for the Y-flat programming language.
GNU General Public License v3.0
6 stars 7 forks source link

added testing workflow into its own file #96

Closed RishiKumarRay closed 2 years ago

RishiKumarRay commented 2 years ago

Close #86

RishiKumarRay commented 2 years ago

@adamhutchings Hi , actually i thought about this but i was getting errors , to implement this can you please tell me individual commands through which you test and compile , i think then i can separate this.

RishiKumarRay commented 2 years ago

@adamhutchings see when i was trying separate this i was getting this error Screenshot from 2022-03-07 22-47-33 maybe i am missing with commands can you tell me

adamhutchings commented 2 years ago

Okay. Then just remove the testing code from compiler.yml and keep the compiling code in testing.

Sophon96 commented 2 years ago

@adamhutchings see when i was trying separate this i was getting this error Screenshot from 2022-03-07 22-47-33 maybe i am missing with commands can you tell me

You didn't build the compiler first. You need to build it with cmake first by running scripts/build.sh first.

adamhutchings commented 2 years ago

I gave wrong advice at first. As you can see, the valgrind workflow builds the project before running valgrind. If you simply remove the part where tests are run in the original compiler file, this will be good to go.

RishiKumarRay commented 2 years ago

@adamhutchings please check now

JakeRoggenbuck commented 2 years ago

Thanks for contributing! Looks great!