search

y-flat / yfc

The best (because it's the only) compiler for the Y-flat programming language.
GNU General Public License v3.0
6 stars 7 forks source link

Add a “tests - passing” badge #97

Closed RishiKumarRay closed 2 years ago

RishiKumarRay commented 2 years ago

Fixed #84

RishiKumarRay commented 2 years ago

@adamhutchings i have done the position changes but to rename the badge with tests instead of test , first can you update inside test.yml name field with tests instead of test?

adamhutchings commented 2 years ago

Done.

RishiKumarRay commented 2 years ago

@adamhutchings i think i have relook at the solution , the issue still persists the badge name is test instead tests. let me see

adamhutchings commented 2 years ago

The badge looks wrong, I think you have an extra [ but it’s hard to tell.

RishiKumarRay commented 2 years ago

@adamhutchings i have tested by doing changes so i think this should work , actually we need to change the workflow name instead of file name. I think this will work now

adamhutchings commented 2 years ago

From my view the badge still looks broken, and now somehow there are merge conflicts. It’s pretty late in my time zone so I’m going to sleep, but I’ll look at it more tomorrow. Again, I really appreciate your contributions.

RishiKumarRay commented 2 years ago

@adamhutchings i checked some references , you need to change name: test to name: tests in tests.yml this will make the workflow name to tests and then we can add the badge , sorry i got confused earlier

adamhutchings commented 2 years ago

Also after my PR is merged you’re going to need to pull from main because there are merge conflicts.

RishiKumarRay commented 2 years ago

sure i will open a new PR @adamhutchings