Open y-ken opened 7 years ago
Hi @okkez @cosmo0920 I'm afraid would you please consider to support for this improvements?
In current (released) version, query
is a top level parameter. Do this plan drops backward compatibilities?
I think query/query/
is not good name.
How about that change default value nest_key
to nil
and remove nest_result
?
This plugin returns nested values if user specify nest_key
parameter. Otherwise this plugin returns flatten values.
row_count
and row_count_key
are ditto with above, too.
Do you want to change record_hostname
, nest_result
, nest_key
, row_count
, row_count_key
per query?
I want to set these parameters only once on top level.
My proposal:
<source>
@type mysql_query
host localhost # Optional (default: localhost)
port 3306 # Optional (default: 3306)
username nagios # Optional (default: root)
password passw0rd # Optional (default nopassword)
interval 30s # Optional (default: 1m)
tag input.mysql # Required
parallel no # Optional (default: no)
record_hostname yes # Optional (default: no)
nest_key data # Optional (default: nil)
row_count_key count # Optional (default: nil)
<query>
query SHOW VARIABLES LIKE 'Thread_%';
</query>
<query>
query SHOW VARIABLES LIKE 'Thread_%';
</query>
</source>
It is the time to improvement for needs satisfaction. Due to support single statement for now, It cause many mysql connection only for fluentd.
plan
query
section. it is similar to fluent-plugin-mysql-statusparallel_execute
to execute query non sequentially.