search

y-ken / fluent-plugin-twitter

Fluentd Input/Output plugin to process tweets with Twitter Streaming API.
https://rubygems.org/gems/fluent-plugin-twitter
Other
53 stars 27 forks source link

require 'string/scrub' if RUBY_VERSION < '2.1' #11

Closed Songmu closed 9 years ago

Songmu commented 9 years ago

string-scrub is specified in gemspec, but is not required in code.

So, I added require clause, and it works in my td-agent with ruby 1.9.3.

y-ken commented 9 years ago

Hi @Songmu Thank you for your pull request :+1:

Songmu commented 9 years ago

Either is OK. I'll fix the code tuning in to your style. It's up to you. What do you think?

y-ken commented 9 years ago

Hi @Songmu It's better to use if RUBY_VERSION.to_f < 2.1 which I think. I isn't good to compare greater or less for string value. And, also add .to_f for fluent-plugin-twitter.gemspec

Thank you.

Songmu commented 9 years ago

Fixed

y-ken commented 9 years ago

Cool. Thank you.

Songmu commented 9 years ago

ありがとうございます！！！

y-ken commented 9 years ago

Hi, @Songmu

It was released as v0.4.1 https://rubygems.org/gems/fluent-plugin-twitter

if you like this repository, please click start button for this. https://github.com/y-ken/fluent-plugin-twitter/stargazers