search

y-ken / fluent-plugin-twitter

Fluentd Input/Output plugin to process tweets with Twitter Streaming API.
https://rubygems.org/gems/fluent-plugin-twitter
Other
53 stars 27 forks source link

Migrate to Fluentd v0.14 API #30

Closed okkez closed 7 years ago

okkez commented 7 years ago

I will rebase this pull request after merge #29 and re-organize .travis.yml.

y-ken commented 7 years ago

29 has merged.

okkez commented 7 years ago

Please release new version of this plugin before merge this pull request.

See details: http://docs.fluentd.org/v0.14/articles/plugin-update-from-v12

okkez commented 7 years ago

This PR works fine with me. I've tested both in_twitter and out_twitter using my tokens in real world.

y-ken commented 7 years ago

Thank you. But is it problem that td-agent2 user cannot install this plugin after this pr has released?

okkez commented 7 years ago

Yes. td-agent2 uses Fluentd 0.12.x not 0.14.x. You can release new version for td-agent2 (Fluentd v0.12.x) users. See also: http://docs.fluentd.org/v0.14/articles/plugin-update-from-v12

okkez commented 7 years ago

Rebased.

y-ken commented 7 years ago

I have released the final version for fluentd v0.12.x as fluent-plugin-twitter v0.6.0 Thus, would you please fix the conflicts? thank you.

y-ken commented 7 years ago

How about keeping backward compatibility like this? https://github.com/sonots/fluent-plugin-record-reformer/commit/077817a99918e72242a9ad630b6fd3e69b2b84ea

okkez commented 7 years ago

How about keeping backward compatibility like this?

No. It's very bad manner. It's too hard to keep maintaining both for Fluentd v0.12.x and v0.14.x.

okkez commented 7 years ago

Rebased and resolved conflicts.

y-ken commented 7 years ago

Today, It has merged! Thank you.