Open AVMatthews opened 7 hours ago
[!IMPORTANT]
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The pull request introduces significant updates to the CMakeLists.txt
file for the CLP project, adding numerous source files related to the clp_s
module and a new end-to-end test case. It modifies the linking process for the unit test executable to include additional libraries. Additionally, it updates JSON test files to reflect new structures and data types, enhancing the complexity of the test scenarios. The overall structure of the CMake configuration remains unchanged, while new functionalities and tests are integrated to improve testing capabilities.
File Path | Change Summary |
---|---|
components/core/CMakeLists.txt | Added multiple source files for clp_s module to SOURCE_FILES_clp_s_unitTest and a new test file test-end_to_end.cpp . Updated target_link_libraries to include MONGOCXX_TARGET and simdjson . |
components/core/tests/test-end_to_end.cpp | Introduced a new end-to-end test case for compression and extraction functionalities, utilizing the Catch2 framework. |
components/core/tests/test_log_files/test_no_floats_sorted.json | Added several JSON objects with various data types, including nested structures and arrays. |
components/core/tests/test_log_files/test_sorted.json | Introduced new fields in JSON objects, including nested objects and arrays, enhancing the complexity of the data structure. |
CMakeLists.txt
files across various components, similar to the main PR's updates to CMakeLists.txt
for the clp
project, indicating a direct connection in terms of build configuration changes.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Adds a test case that runs the full clp-s pipeline from JSON to archive and back to JSON to ensure data consistency. Adds corresponding example JSON files to test on.
Note: Due to discrepancies in the number of significant digits produces in the reconstruction of the JSON file, the current JSON file used in the test, does not contain floats. I leave testing of float value accuracy to a later time.
Validation performed
Compiled and ran the test to ensure that the REQUIRE statements are met and manually checked output files to see that the correct data is produced.
Summary by CodeRabbit
New Features
clp_s
module, enhancing functionality for data handling and processing.Bug Fixes
Documentation