Closed davemarco closed 4 days ago
The pull request introduces substantial updates to the user guide for the YScope Log Viewer, enhancing both its structure and content. It replaces placeholder text with a grid layout featuring three informative cards linked to relevant documentation sections. Additionally, new documentation is added on formatters, log formatting capabilities, syntax for format strings, and log-level filtering methods. The .gitattributes
file is updated to manage PNG files with Git LFS, and a new section on viewing logs is introduced, detailing how to access both local and remote log files.
File Path | Change Summary |
---|---|
docs/src/user-guide/index.md | Replaced placeholder text with a structured grid layout including links to "Quick start," "Formatting structured logs," and "Log level filtering." Added toctree directives for better organization. |
docs/src/user-guide/.gitattributes | Added configuration for PNG image files to be handled by Git LFS with appropriate attributes. |
docs/src/user-guide/format-struct-logs-formatters.md | Introduced a new section detailing the Timestamp and Round formatters, including usage examples. |
docs/src/user-guide/format-struct-logs-overview.md | Added an overview of the log viewer's capability to format structured logs with examples and references. |
docs/src/user-guide/format-struct-logs-syntax.md | Created a comprehensive guide on format string syntax, detailing components and providing examples. |
docs/src/user-guide/log-level-filtering.md | Updated to include methods for filtering logs by severity levels, illustrated with images. |
docs/src/user-guide/quick-start.md | Added a new section on "Viewing logs," detailing how to open local and remote log files. |
LogFileManager
class to support log level filtering, which is directly related to the changes in the main PR that introduces structured documentation for log level filtering.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The suggestions lgtm. Feel free to commit them so that you remain the last pusher.
For the PR title, how about:
docs: Add user docs for opening log files, level filtering, and formatting structured logs.
Can we also add (fixes #86)
in the PR title?
@junhaoliao technically, this dosent fix 86? it was already fixed by another PR. These docs just refer to nested logs.
@junhaoliao technically, this dosent fix 86? it was already fixed by another PR. These docs just refer to nested logs.
Right, we could have closed issue #86 in PR #123 , but now the docs are added which completes the feature. Anyways, the PR and the issue has now been linked and i think it's fine not mentioning the issue in this PR title.
Description
This PR is a starting point for the user guide. More can be added later.
I added sections for opening files, format string, and log level filtering.
For the format string. I added a simple example for the overview (I thought including only the full spec might overwhelm users). I also kept the full spec in another page. I also added a list of current field formatters.
Validation performed
Docs still work.
Summary by CodeRabbit
New Features
Documentation