search

y-takey / atom-mermaid

Preview mermaid on atom editor
MIT License
42 stars 7 forks source link

Changes required for upcoming CoffeeScript upgrade #33

Closed maxbrunsfeld closed 7 years ago

maxbrunsfeld commented 7 years ago

Hi! Thanks for maintaining the atom-mermaid package!

In Atom v1.12, we are going to upgrade CoffeeScript to the latest version. This upgrade entails one potentially breaking change to the language:

Changed strategy for the generation of internal compiler variable names. Note that this means that @example function parameters are no longer available as naked example variables within the function body.

We think your package may be affected by this upgrade, in the following places:

These findings are based on linting packages with coffeescope. We could be wrong about some of them. When we release v1.12 beta, please test your package against it to make sure that it works. Let me know if you have any further questions; I will be happy to help!

y-takey commented 7 years ago

Hi @maxbrunsfeld , Thanks for the help.I will test it soon!

y-takey commented 7 years ago

I changed completely. Thank you very much.