y-takey / atom-mermaid

Preview mermaid on atom editor
MIT License
42 stars 7 forks source link

Preview tool is not rendering #43

Closed gregorym closed 7 years ago

gregorym commented 7 years ago

I am using Atom 1.20

See screenshot: screen shot 2017-09-26 at 6 49 47 pm

y-takey commented 7 years ago

Hi @gregorym ,

Thanks for the report :) I tried following environment, but can't reproduce the issue.

Atom: 1.20.1
atom-mermaid: 3.1.0
OS: macOS 10.12.6

here is tried code:

sequenceDiagram
  Alice ->> Bob: Hello Bob, how are you?
  Bob-->>John: How about you John?
  Bob--x Alice: Ia am good thanks!
  Bob-x John: I am good thanks!
  Note right of John: Bob thinks a long<br/>long time, so long<br />that the text does<br/>not fit on a row.

  Bob-->Alice: Checking with Jonhn...
  Alice->John: Yes... John, how are you?

Could you try to copy&paset your code to mermaid-live-editor ? if the result don't works fine, could you show me your code?

gregorym commented 7 years ago

It works fine in the live editor. Also I do not see any error logs from the dev console.

@y-takey What do you mean show you my code?

y-takey commented 7 years ago

To isolate the problem, I tried to check whether there is the problem on your codebase(mermaid markdown) or on the plugin side. it worked fine in the live editor, then your codebase is correct probably.

What is the version of atom-mermaid you are using?

gregorym commented 7 years ago

I have the exact same config as yours:

Atom: 1.20.1
atom-mermaid: 3.1.0
OS: macOS 10.12.6

Here's what I found when I restart Atom with the Dev Tools open:

No deserializer found for 
Object
deserializer: "MermaidView"
y-takey commented 7 years ago

I think there is no problem about the message, because preview tab is not saved(serialize&deserialize) currently.

umm, sorry i have no clue why. Did you try it after uninstall atom-mermaid and reinstall one?

gregorym commented 7 years ago

I did. Same behavior :(

y-takey commented 7 years ago

Thanks for the try. I have two suggestions.

  1. Could you show me your mermaid markdown as a file? There is invisible characters maybe.
  2. Could you try with a simple markdown? e.g.)
    sequenceDiagram
    Alice->> Bob: Hi
zachintosh commented 7 years ago

Hi y-takey,

I am having the same issue. Just wanted to let you know it's not an isolated issue.

I'm on Atom 1.22.0-beta0, and on the most recent version of atom-mermaid. We use mermaid quite a bit where I work, so finding this package was a victory. I'll keep trying to figure out what's wrong.

Thanks!

y-takey commented 7 years ago

Hi @zlw11063 ,

Thank you for your comment. :) I finally succeeded in identifying the cause. so I've fixed the issue, and published a newer version(3.2.1). Could you try with latest atom-mermaid when you have time?

Thanks!

gregorym commented 7 years ago

@y-takey The problem is solved. Thanks for finding the issue and resolving it.

y-takey commented 7 years ago

Many thanks!