y-takey / atom-mermaid

Preview mermaid on atom editor
MIT License
42 stars 7 forks source link

atom-mermaid | Using subgraphs does not render required results #52

Closed pjHealthQ closed 6 years ago

pjHealthQ commented 6 years ago

Sample code used (from https://mermaidjs.github.io/flowchart.html)

graph TB
    c1-->a2
    subgraph one
    a1-->a2
    end
    subgraph two
    b1-->b2
    end
    subgraph three
    c1-->c2
    end

atom-mermaid not using subgraph image atom-mermaid using subgraph image atom-mermaid using subgraph image error on export

y-takey commented 6 years ago

Hi @pjHealthQ , thanks for your report :)

I've upgraded mermaid to v8.0.0, then the issue is fixed. Could you retry after update your atom-mermaid 3.3.0?

2018-05-14 21 06 31

ghost commented 6 years ago

Trying to update gives me this error:

npm ERR! Darwin 17.5.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/marcus/.atom/.apm/.apmrc" "--userconfig" "/Users/marcus/.atom/.apmrc" "install" "/private/var/folders/zb/hvlznjv13kl9d4fgg3c47qwc0000gn/T/d-118414-82556-rwqxzf.prv6os9k9/package.tgz" "--runtime=electron" "--target=1.7.11" "--arch=x64" "--global-style"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10
npm ERR! code ETARGET

npm ERR! notarget No compatible version found: mermaid@8.0.0
npm ERR! notarget Valid install targets:
npm ERR! notarget 8.0.0-rc.8, 8.0.0-rc.7, 8.0.0-rc.6, 8.0.0-rc.5, 8.0.0-rc.4, 8.0.0-rc.3, 8.0.0-rc.2, 8.0.0-rc.1, 8.0.0-beta.9, 8.0.0-beta.8, 8.0.0-beta.7, 8.0.0-beta.6, 8.0.0-beta.5, 8.0.0-beta.4, 8.0.0-beta.3, 8.0.0-beta.2, 8.0.0-beta.1, 8.0.0-alpha.9, 8.0.0-alpha.8, 8.0.0-alpha.6, 8.0.0-alpha.5, 8.0.0-alpha.4, 8.0.0-alpha.3, 8.0.0-alpha.2, 8.0.0-alpha.1, 7.1.2, 7.1.1, 7.1.0, 7.0.18, 7.0.17, 7.0.16, 7.0.15, 7.0.14, 7.0.13, 7.0.12, 7.0.11, 7.0.10, 7.0.9, 7.0.8, 7.0.7, 7.0.6, 7.0.5, 7.0.4, 7.0.3, 7.0.2, 7.0.1, 7.0.0, 6.0.0, 0.5.8, 0.5.7, 0.5.6, 0.5.5, 0.5.4, 0.5.3, 0.5.2, 0.5.1, 0.5.0, 0.4.0, 0.3.5, 0.3.4, 0.3.3, 0.3.2, 0.3.0, 0.2.16, 0.2.15, 0.2.14, 0.2.13, 0.2.12, 0.2.11
npm ERR! notarget 
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget 
npm ERR! notarget It was specified as a dependency of 'atom-mermaid'
npm ERR! notarget 

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/zb/hvlznjv13kl9d4fgg3c47qwc0000gn/T/apm-install-dir-118414-82556-1nakxrg.7uml4hd7vi/npm-debug.log
y-takey commented 6 years ago

sorry, I missed to specify mermaid rc version. Could you retry after update your atom-mermaid (v3.3.1)?

pjHealthQ commented 6 years ago

Thank you y-takey

I had to delete and reinstall Atom for some reason yesterday (kept on crashing) — but after a reinstall and installing atom-mermaid v3.3.1 the problem was fixed.

Appreciate the help.

JC