search

y-takey / atom-mermaid

Preview mermaid on atom editor
MIT License
42 stars 7 forks source link

"Save As" from preview pane doesn't work anymore #74

Closed jyutzler closed 3 years ago

jyutzler commented 3 years ago

Expected Behavior

When I use the Save As tool, I get a nice PNG of the rendered UML.

Actual Behavior

The operation fails silently. No files are altered.

Steps to Reproduce

  1. Install Mermaid for Atom v.3.6.0
  2. Create a Mermaid class diagram, e.g., https://github.com/jyutzler/geopackage/blob/conceptual-model/spec/conceptual-model/UML/core.uml
  3. Toggle Preview in Atom
  4. Right-click, "Save as PNG"
  5. Choose a file name

This did work at one time but it no longer does. I have tried this on two different machines running different operating systems. It is not clear to me what the problem could be so I am starting here.

y-takey commented 3 years ago

Hi @jyutzler , Thanks for the issue :) I could't reproduce this issue on macOS 11.4. What is your OS?

jyutzler commented 3 years ago

macOS 11.3 or Windows 10 Pro (19042.1052). I'm guessing the issue is with some low-level library, but I don't know how to diagnose it.

wilwade commented 3 years ago

Same issue.

macOS 11.3 Atom 1.57.0

joshwells commented 3 years ago

Same issue with Atom 1.57.0 and macOS 10.15.7

Issue started with an Atom update. I have Atom 1.55.0 working for now.

y-takey commented 3 years ago

@joshwells Thanks the detail info. I will try to fix this issue.

y-takey commented 3 years ago

fixed this issue, and published atom-mermaid@3.7.1 .

joshwells commented 3 years ago

Fix confirmed with Atom@1.58.0 and atom-mermaid@3.7.1. Thanks so much for taking care of this!