search

y-young / userscripts

A collection of self-made userscripts.
MIT License
8 stars 3 forks source link

Nothing happens on mobile #4

Closed jesus2099 closed 2 years ago

jesus2099 commented 2 years ago

Hi @y-young, congratulations for this new script! I am not so often on my PC so I tried it on my Android 9 Firefox for Android 68.11.0 with Violentmonkey 2.13.0.

Clicking the Import into MusicBrainz then nothing happens.

I agree this ticket is a very low priority issue, as it is already difficult to have a userscript enabled setup on mobile.

Even more difficult to debug, as you need to install an obsolete version Firefox on PC (I use a portable version 68 for this).

y-young commented 2 years ago

Hi @jesus2099 , I installed Firefox 68.11.0 on my PC and it worked fine for me, but I noticed that it asked for the permission of pop-up. I'm not sure if it's the same on mobile, can you provide details about this? For example, what did you do in specific? Have you opened the modal before clicking? Can you see any console logs? Have you tried on your PC?

jesus2099 commented 2 years ago

Thanks for testing! But I will probably work on it myself through a PR, as I think your code seems compact and clear.

I think it's a mobile-only issue.

jesus2099 commented 2 years ago

Nothing happens in the logs.

I noticed that it asked for the permission of pop-up

Exactly that!

In fact, Violentmonkey monkey menu on Firefox for Android is a full new tab, that auto closed when you leave it, but not on click.

So when I clicked the option there, it would certainly ask for popup permission in the now background minc tab. But I was in the monkey menu tab, and even when switching back to minc tab, the permission question was no longer there.

I modified your script and added a setTimeout(function(){.click()}, 1000) to allow me time to switch back to minc tab before the .click(). Thus it asked pop-up permission and I allowed it once for all.

I understand the difficulty of having the import button visible in this minc Ajax tracklist modal instead of using the monkey menu. And I must be the only user on Firefox for Android 68. 🤭