Open hmhummel opened 2 months ago
To address this, I plan to:
causal.effect
using expr = FALSE
to ensure that the correct input is being used for parse.expression
, which calls simplify
. parse.expression
unit test using this input. parse.expression
to input into simplify
, and update the simplify
unit test. test_that
unit test, but also iterates correctly through simplify
so that I can obtain the inputs for join
.
See issue #2.
I have been able to create
join
unit tests for Vignettes 1 and #3 becausejoin
is called bysimplify
. However, I have not been able to create thejoin
unit test for Vignette 2 becausesimplify
does not iterate all the way through, although the unit test passes thetest_that
test.I created the unit tests for 1 and 3 by running
simplify
with breakpoints on each vignette (e.g.simplify(P_3_s1 (or s2), topo_3, G_3.unobs, G_3, G_3.obs)
) using the browser() function. I added print statements after step 5 insimplify
, and printed theJ
,D
,vari
,cond
,S
,M
, andO
that result after this step. Note that:P$children[[k]]$var
=var
,P$children[[k]]$cond:
=cond
,P$sumset[j]
=S
.When I attempt to similarly run
simplify
with breakpoints for Vignette 2, it only iterates through the first step and skips to step 8 (the last step).