search

y0014984 / Advanced-Equipment

Advanced Equipment is a Arma 3 mod, that brings equipment to life, like laptops and lamps.
Other
25 stars 9 forks source link

Add columnar transposition cipher #344

Closed JulesVerner closed 1 year ago

JulesVerner commented 1 year ago

This PR adds the columnar transposition cipher as an alternative for the already implemented caesar cipher. So far, it's only an additional algorithm-option for the crypto-command and does not have an implementation for the crack-command. I added a corresponding wiki-suggestion in the wiki folder; Although the explanation might be a bit complicated. Looking forward to hearing your thoughts on this! 😄

y0014984 commented 1 year ago

Thank you for this contribution. I will have a look into it tomorrow.

y0014984 commented 1 year ago

I forgot to mention: please add all languages to the stringtable.xml. You can use the english version but please add the tags for all currently supported languages. This is easier for our translators und prevents formatting issues. Thank you.

JulesVerner commented 1 year ago
  • Use blank spaces to fill rows on encryption and decryption instead of random chars

I would suggest using '_' or similar special characters, instead of spaces. Spaces appended to the end of the message are not visible in the console and therefore it's likely that a false encrypted message will be used. Also, as far as I know, trailing spaces in the messages will be cut off, when calling the commands.

y0014984 commented 1 year ago

I would suggest using '_' or similar special characters, instead of spaces.

Do it. We will see how it behaves.