y007at / google-axs-chrome

Automatically exported from code.google.com/p/google-axs-chrome
0 stars 0 forks source link

Longdesc key shortcut already used for other function #141

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Navigate to an image with a longdesc (ChromeVox correctly announces that the 
image does have a long description)
2. Use ChromeVox+C > D as listed in the keyboard commands (ChromeVox+.)

What is the expected output? What do you see instead?

Expected output is to "Open long description in a new tab". What actually 
happens is the *other* command that's already mapped to that key 
combination/sequence, "Speak the current time and date", is executed.

What version of the product are you using? On what operating system?

1.31.4, Chrome 34, Windows 8.1

Please provide any additional information below.

This seems to be a simple case of using a keyboard shortcut/sequence that is 
already used by ChromeVox. Suggest changing the sequence to ChromeVox+C > L (as 
in Opera's ChromeVox fork's mapping 
https://github.com/operasoftware/chromevox/search?q=openLongDesc&type=Code)

Original issue reported on code.google.com by splinte...@gmail.com on 1 May 2014 at 10:17

Attachments:

GoogleCodeExporter commented 8 years ago
i.e. the fix is here:

https://code.google.com/p/google-axs-chrome/source/browse/trunk/chromevox/chrome
vox/background/keymaps/classic_keymap.json

 {"command": "openLongDesc",
  "sequence": {"cvoxModifier": true,
               "keys": {"keyCode": [67, 68]}
              }},

change to

 {"command": "openLongDesc",
  "sequence": {"cvoxModifier": true,
               "keys": {"keyCode": [67, 76]}
              }},

Original comment by splinte...@gmail.com on 1 May 2014 at 10:22

GoogleCodeExporter commented 8 years ago
When rolled out in version 1.26 [1] Cvox+C>D had worked fine. 

Subsequently that keyboard shortcut must have been assigned to another purpose.

Please restore a longdesc key shortcut. Thank you.

[1] 
https://web.archive.org/web/20130326192946/http://www.chromevox.com/release_note
s.html

Original comment by laura.le...@gmail.com on 1 May 2014 at 7:34

GoogleCodeExporter commented 8 years ago
So either change the sequence for "Speak the current time and date"

{"command": "speakTimeAndDate",
  "sequence": {"cvoxModifier": true,
               "keys": {"keyCode": [67, 68]}
              }},

to some other keys to allow Cvox+C>D to work again as in 1.26, or officially 
remap longdesc to something like Cvox+C>L as proposed above, and explicitly 
note it in release notes...

Original comment by splinte...@gmail.com on 1 May 2014 at 7:44