y0c / react-datepicker

📅 React DatePicker Library (Flexible, Reusable)
https://y0c.github.io/react-datepicker
MIT License
168 stars 32 forks source link

use weekday fn from days.js to respect locale weekday reordering #46

Closed flo-l closed 4 years ago

flo-l commented 4 years ago

eg. MO-SO instead of SO-SA

flo-l commented 4 years ago

The tests are green on my box.

flo-l commented 4 years ago

I had to bump the dayjs dependency to get the weekday functionality.

The current version in the package is 1.8.12. Weekday came one release later, in 1.8.13. I updated to the latest version: 1.8.21. However, I can change that if you prefer.

flo-l commented 4 years ago

hmm I can't run yarn install locally. I get an error during gyp compilation. @y0c could you please update the yarn lockfile?

y0c commented 4 years ago

@flo-l I update yarn lockfile to dev branch.

flo-l commented 4 years ago

thank you!

I'm afraid I can't build the current master on my machine. I get compile errors during yarn install. I'm on Fedora Linux with Node 12.15.

I can get the build to pass if I bump node-sass from 4.11.0 to 4.12.0.

flo-l commented 4 years ago

thank you!

I'm afraid I can't build the current master on my machine. I get compile errors during yarn install. I'm on Fedora Linux with Node 12.15.

I can get the build to pass if I bump node-sass from 4.11.0 to 4.12.0.

Well I'm an idiot and didn't pull from your repo, but from my fork. It works now.

I changed the type of Locale from any to string | ILocale. If that is not what you intended I'll revert this change!

y0c commented 4 years ago

Well done. Thank you.

flo-l commented 4 years ago

Well done. Thank you.

Thank you too for your lib and the merge :)

flo-l commented 4 years ago

One last request: Could you please do a release so I can use upstream in my project?

y0c commented 4 years ago

@flo-l update version 1.0.3