search

y0rdie / laravel-gust

Laravel Gust is a backend agnostic VueJS authentication frontend for Laravel.
MIT License
19 stars 1 forks source link

Unit Tests #6

Closed mauriciovillam closed 3 years ago

mauriciovillam commented 3 years ago

Hey Sam!

Thanks for submitting this piece of work to the Laravel community. I would recommend to introduce some unit tests and do some separation of concerns: perhaps the InstallCommand does too much. This package may require changes if any stack changes (fortify, breeze, or ui), so tests will help you a lot to track these issues.

Best of luck!

y0rdie commented 3 years ago

Hey Mauricio,

Thanks for taking the time to look at the package and I appreciate your feedback, feel free to submit a PR if you'd like to improve on anything.

All the best, Sam