Makefile modifications

[GoogleCodeExporter]

On Fri, Aug 5, 2011 at 12:45 AM, Jeffrey Walton <noloader@gmail.com> wrote:
> On Fri, Aug 5, 2011 at 12:36 AM, Kevin W. Wall <kevin.w.wall@gmail.com> wrote:
>> Why not use 'debug' for all tests?
> OK, it can be default if you prefer.

At least for the near term. Most of the time, the purpose of writing and
running tests goes hand-in-glove with debugging your code and/or
the tests themselves, so I think debug makes sense for the default
case here.

>> Why would you ever compile tests w/out debug?
> To track down optimization bugs.

OK, valid point...assuming that we have suitable tests. Also, debugging
(or at least debug output) can mask race conditions, so I think you make
a legitimate point. But I think the normal case should still be to
compile with debugging enabled.

>> As for libesapi++.so itself, there can be a
>>
>>    make production
>>
>> which just recursively calls make with RELEASE_BUILD=1 on the command line
>> and the default would be to build libesapi++.so with 'debug' enabled.
> How about `make release`?

Yes; +1; I like 'make release' much better.

>> That's going
>> to be the normal mode for us, probably even for the Release Candidate builds.
> Forgive my ignorance. `make production` should set `RELEASE_BUILD=1`
> but create libesapi++.so with 'debug' enabled?
>
> I'm probably adding to the confusion. A Debug Build has two things in my eye:
>  * no optimizations (O0)
>  * maximum degug info (g3)

AND (IMO), probably -DDEBUG as well.

> A Release build is the opposite:
>  * moderate optimizations (O2)
>  * minimum degug info (g)

OK, I'll buy that.  And probably -DNDEBUG for *final*
releases builds (but NOT for release candidate builds).

> So do you want moderate optimizations and maximum debug info?

Yes.

Original issue reported on code.google.com by noloa...@gmail.com on 6 Aug 2011 at 7:52

[GoogleCodeExporter]

Fixed at R121.

Original comment by noloa...@gmail.com on 9 Aug 2011 at 2:52

[GoogleCodeExporter]

Changed status to 'Fixed'.

Original comment by kevin.w.wall@gmail.com on 9 Aug 2011 at 3:07

• Changed state: Fixed

[GoogleCodeExporter]

I changed its status to 'Fixed' since you have fixed it.

Original comment by kevin.w.wall@gmail.com on 9 Aug 2011 at 3:09