search

y20k / transistor

Transistor - Simple Radio App for Android
http://y20k.org/transistor/
MIT License
437 stars 121 forks source link

fix icon color on light theme #318

Closed jamal2362 closed 3 years ago

jamal2362 commented 3 years ago

This will fix the more icon color on the light theme.

y20k commented 3 years ago

Wow @jamal2362 you have good eye sight. The more icon and the play icon indeed have different colors. The difference is intentionally, although your pull request makes me reconsider.

Let me explain: The more icon has the same color as the text. I tried both in the slightly darker grey the play button has, but I found both "popped out" too much. I still feel that, looking at the change.

But you are probably right: the play and more icons should have the same color, since they both are the same kind of UI element on the same canvas/background.

I will install the fix on my phone an see how it feels. :-)

jamal2362 commented 3 years ago

I only noticed the whole thing after a few months :D

This is what the before and after comparison looks like :)

Before: Screenshot_20201207-183346

After: Screenshot_20201207-183336