search

y20k / transistor

Transistor - Simple Radio App for Android
http://y20k.org/transistor/
MIT License
437 stars 121 forks source link

Migrate to ActivityResult APIs #357

Closed TacoTheDank closed 3 years ago

TacoTheDank commented 3 years ago

As of Fragment 1.3.0 (which AppCompat 1.3.0 uses internally), we can now use the ActivityResult APIs.

y20k commented 3 years ago

Thanks! I did not know that such a thing as ActivityResultContracts exists. I need to implement this in my other apps!

TacoTheDank commented 3 years ago

Thanks! I did not know that such a thing as ActivityResultContracts exists. I need to implement this in my other apps!

I've got you covered for trackbook. I can do it for escapepod too if you'd like, though you'd need to update the AndroidX libraries first. :)

y20k commented 3 years ago

I need to implement this in my other apps

😄 I admit that I hoped that you would have a look. But wow you are fast. Thanks!!

And yes. If you find the time, I would really appreciate, if you could implement ActivityResultContracts for Escapepod, too. The only thing: I think I have some not yet committed code on one of my computers. I would like to push that first to minimize merge conflicts. I will drop a comment here if I really have something not yet committed.

TacoTheDank commented 3 years ago

And yes. If you find the time, I would really appreciate, if you could implement ActivityResultContracts for Escapepod, too. The only thing: I think I have some not yet committed code on one of my computers. I would like to push that first to minimize merge conflicts. I will drop a comment here if I really have something not yet committed.

Sounds good to me 👍

y20k commented 3 years ago

I remembered correctly still had some un-committed changes hanging around on one of my computers. I pushed them today. You now may start and have a look, if it makes sense to add ActivityResultContracts for Escapepod. Only if it fits your schedule obviously. No hurry here. :vulcan_salute: