CollectionViewModel fixes/improvements

y20k / transistor

Transistor - Simple Radio App for Android

http://y20k.org/transistor/

MIT License

433 stars 121 forks source link

Closed loki666 closed 2 years ago

loki666 commented 2 years ago

uiScope is not needed, viewModelScope extension is the same
deferred collection is not needed (async {} will launch a new unnecessary coroutine)
run readCollectionSuspended in Dispatcher.IO (the client of readCollectionSuspended shouldn't dictate which context to run this)

y20k commented 2 years ago

Thank you!! I remember writing the code at a time when I wasn't sure how to use coroutines.

loki666 commented 2 years ago

I'll probably submit more fixes regarding coroutines