y20k / transistor

Transistor - Simple Radio App for Android
http://y20k.org/transistor/
MIT License
433 stars 121 forks source link

Swipe to delete is unintuitive to new users. #393

Open will-lol opened 2 years ago

will-lol commented 2 years ago

Is your feature request related to a problem? Please describe. I downloaded Transistor today (and loved it!) but it took me ages to figure out how to delete a station. I ended up just clearing the data for the app to delete them all. It took me looking at the issues page on GitHub to figure out that swiping on the station was the solution.

Describe the solution you'd like Add a delete button to the 3 dot menu that displays the swipe animation to hint to the user that they can swipe to delete instead.

Describe alternatives you've considered When renaming a station to blank, delete it and display the swipe animation to hint to the user that they can swipe to delete instead.

y20k commented 2 years ago

Hi & thanks for reporting the problem!!

I always thought that swipe to delete is a common gesture. I need to reconsider it.

The suggested solution can not be implemented, since the options menu is on its way out. See https://github.com/y20k/transistor/issues/389#issuecomment-1018520375

I could place a delete button in new inline dialog. But I am not 100% convinced at the moment.

timi10x commented 2 years ago

I'd like to contribute to this project by starting with adding the delete button. I also have an idea of adding a text notifying the user of the swipe to delete action, when the delete button is clicked on first interaction

does that sound convincing? @y20k

y20k commented 2 years ago

Hi @timmyCoder

the Delete button in question would be a text button on the left of the inline Edit dialog.

The new Edit dialog itself will be accessible via long press only (I think of it as a power user feature). There will be a hint on how to activate Edit in Settings.

I'd like to contribute to this project by starting with adding the delete button.

I think I (and we) need to experience the new Edit user interface before starting work on a Delete button. Especially since adding a Delete button implicates the removal of Swipe to Delete. I believe there should only one way to Delete a station. So in the end the Delete action may end up being less accessible than before.

So to answer your question: let's wait a bit before starting to work on this.

Just FYI: I did not release the changes you can see in the screenshot, because I really want #386 to be solved first. Btw. if you have knowledge in ExoPlayer and or Notifications. I need a fresh eyes onto the problem. :-)

y20k commented 2 years ago

Another idea I had to increase the visibility of the swipe gesture was btw.: Show a Snackbar above the play controls when user adds his/her fist radio station: "Use swipe gestures to favorite or delete a radio station [Got It]"

timi10x commented 2 years ago

alrighty, I'd take a look at that one

y20k commented 2 years ago

I really want https://github.com/y20k/transistor/issues/386 to be solved first.

Just FYI. This one is fixed now :-)