y20k / transistor

Transistor - Simple Radio App for Android
http://y20k.org/transistor/
MIT License
433 stars 121 forks source link

Crash while add custom stream link #411

Open illegalpotato opened 2 years ago

illegalpotato commented 2 years ago

App crashes when i try to add m3u8 link

Tap on "add station" Paste .m3u8 link App crashed No station added No errors showing

Last version (4.1.0)

termdew commented 2 years ago

m3u8 files can contain multiple streams. Have a look at this m3u8 File from bigFM for example:

bigFm m3u8

Transistor doesn't know which stream to play and therefore doesn't do anything.

We should implement a dialogue where we can select the streams from the m3u8 which should be added.

@y20k What do you think about this?

y20k commented 2 years ago

Hi @illegalpotato

can you post an .m3u8 link that leads to a crash? I would greatly help finding the bug.

y20k commented 2 years ago

Hi @termdew

the problem you are describing is probably another issue. A lot of playlist files für radio stations (m3u, pls, m3u8) contain multiple entries.

Transistor only saves the first entry. You example contains 26(!) stations.

When handed a playlist file Transistor should show a dialog where a user can select which station(s) he/she wants to import. There is a ticket for this issue (#330). The import feature would be useful for the example you gave. It would also be useful if a user wants to import a list of radio stations exported from another app.

illegalpotato commented 2 years ago

Hi @y20k, shure: https://ilsole24ore-radio.akamaized.net/hls/live/2035301/radio24/playlist-64000.m3u8 I tried to VLC and MX Player and it worked

y20k commented 2 years ago

Hi @illegalpotato

THX!! The stream address you posted is a HLS stream. HLS is only half-supported at the moment. The app should not crash when processing it though. I found the bug that was causing it.