search

y252328 / Instagram_Download_Button

Add download button to download media in the post and the story in Instagram
MIT License
234 stars 32 forks source link

Small changes to make the script work again #41

Closed sn-o-w closed 1 year ago

sn-o-w commented 1 year ago

It's a bad idea to look up for share button. The share button is missing for private account posts. It would make more sense to look up for Like or Save button.

emb8051 commented 1 year ago

I agree with the issue you have raised but in your implementation I think there is a headache that needs to be avoided (if it's possible at all). IG likes to change up the class names so keying off that is going to frequently break the script. Keying off the share button was a nice way to avoid having an arms race between IG changing the class names and script maintainers having to update. That was until IG decided to remove the share button for private profiles. :-/

But here is the real kicker... I've observed the class names change and then revert back to the old ones days later. So if it is decided that we have to use class names, we're going to have to keep a running list of past ones too and hope they aren't recycled elsewhere. :-/

sn-o-w commented 1 year ago

@emb8051 Oh, I see.

sn-o-w commented 1 year ago

@y252328 Are you gonna update this repo? The latest version is now v1.17.6, and I wanted to submit a new PR based on v1.17.6