y42 / clj-druid

Eclipse Public License 1.0
31 stars 10 forks source link

Problems in README.md #28

Open dcerys opened 3 years ago

dcerys commented 3 years ago

I just started looking at this, since I need to access Druid from Clojure.

I noticed a couple of problems in the top-level README.md file:

  1. random isn't defined, as in (query client random (:queryType q) q). Maybe you meant randomize?
  2. execute isn't defined, as in (execute client random q)

Also, I'd appreciate a quick comment confirming whether this package should work (since I'm having some other exceptions). I'm using Clojure 1.8 (admittedly old). Thanks, Dan

dcerys commented 3 years ago

I just updated to 0.2.19-SNAPSHOT, and things are much better:

The problem with random vs randomize still exists.

I strongly suggest deploying 0.2.19-SNAPSHOT as 0.2.19 to clojars (while fixing the README.md), to provide a working version to developers. Now that I'm using 0.2.19-SNAPSHOT, and things are working, I'm appreciative of you putting this package together. Thanks!