Open GoogleCodeExporter opened 8 years ago
Are these patches against 0.16.x or trunk?
I'm hesitant to change the next_announce_in() and min_announce_in() return
types, since these are user-facing and might potentially break user code. I
wouldn't imagine this value to ever need more than 32 bits though.
as for naming the exception in the catch blocks, wouldn't this just trade a
warning for "unused parameter" warning?
I changed the cast in the DHT to be an unsigned 64 bit integer instead (that's
the range of the internal sequence number).
The changes to time.cpp don't seem correct to me. you changed the width of the
types passed into snprintf() without changing the format codes.
Original comment by arvid.no...@gmail.com
on 10 May 2014 at 2:48
I've checked-in most of your patches, with some slight modifications, in [9949].
Do you think this is sufficient?
Original comment by arvid.no...@gmail.com
on 10 May 2014 at 3:25
Original issue reported on code.google.com by
tho...@thomasfischer.biz
on 9 May 2014 at 7:10