y7kim / agency-jekyll-theme

Agency Theme for Jekyll
Apache License 2.0
868 stars 2.02k forks source link

vendor links aren't resolving #130

Open byldhyre-dev opened 1 year ago

byldhyre-dev commented 1 year ago

Am I doing something obviously wrong here?

Thanks.

Gemfile

source "https://rubygems.org"
# Hello! This is where you manage which Jekyll version is used to run.
# When you want to use a different version, change it below, save the
# file and run `bundle install`. Run Jekyll with `bundle exec`, like so:
#
#     bundle exec jekyll serve
#
# This will help ensure the proper Jekyll version is running.
# Happy Jekylling!
# gem "jekyll", "~> 4.3.2"

# This is the default theme for new Jekyll sites. You may change this to anything you like.
gem "agency-jekyll-theme", "~> 1.0"

# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
gem "github-pages", group: :jekyll_plugins
# If you have any plugins, put them here!
group :jekyll_plugins do
  gem "jekyll-feed", "~> 0.12"
end

# Windows and JRuby does not include zoneinfo files, so bundle the tzinfo-data gem
# and associated library.
platforms :mingw, :x64_mingw, :mswin, :jruby do
  gem "tzinfo", ">= 1", "< 3"
  gem "tzinfo-data"
end

# Performance-booster for watching directories on Windows
gem "wdm", "~> 0.1.1", :platforms => [:mingw, :x64_mingw, :mswin]

# Lock `http_parser.rb` gem to `v0.6.x` on JRuby builds since newer versions of the gem
# do not have a Java counterpart.
gem "http_parser.rb", "~> 0.6.0", :platforms => [:jruby]

# https://github.com/jekyll/jekyll/issues/8523
gem "webrick"

Config

# Welcome to Jekyll!
#
# This config file is meant for settings that affect your whole blog, values
# which you are expected to set up once and rarely edit after that. If you find
# yourself editing this file very often, consider using Jekyll's data files
# feature for the data you need to update frequently.
#
# For technical reasons, this file is *NOT* reloaded automatically when you use
# 'bundle exec jekyll serve'. If you change this file, please restart the server process.
#
# If you need help with YAML syntax, here are some quick references for you:
# https://learn-the-web.algonquindesign.ca/topics/markdown-yaml-cheat-sheet/#yaml
# https://learnxinyminutes.com/docs/yaml/
#
# Site settings
# These are used to personalize your new site. If you look in the HTML files,
# you will see them accessed via {{ site.title }}, {{ site.email }}, and so on.
# You can create any custom variable you would like, and they will be accessible
# in the templates via {{ site.myvariable }}.

title: Your awesome title
email: your-email@example.com
description: >- # this means to ignore newlines until "baseurl:"
  Write an awesome description for your new site here. You can edit this
  line in _config.yml. It will appear in your document head meta (for
  Google search results) and in your feed.xml site description.
baseurl: "" # the subpath of your site, e.g. /blog
url: "" # the base hostname & protocol for your site, e.g. http://example.com
twitter_username: jekyllrb
github_username:  jekyll

# Build settings
theme: agency-jekyll-theme 
plugins:
  - jekyll-feed

# Exclude from processing.
# The following items will not be processed, by default.
# Any item listed under the `exclude:` key here will be automatically added to
# the internal "default list".
#
# Excluded items can be processed by explicitly listing the directories or
# their entries' file path in the `include:` list.
#
# exclude:
#   - .sass-cache/
#   - .jekyll-cache/
#   - gemfiles/
#   - Gemfile
#   - Gemfile.lock
#   - node_modules/
#   - vendor/bundle/
#   - vendor/cache/
#   - vendor/gems/
#   - vendor/ruby/

Logs

❯ jekyll serve --incremental
Configuration file: ~/Code/my_project/my_project.github.io/_config.yml
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
            Source: ~/Code/my_project/my_project.github.io
       Destination: ~/Code/my_project/my_project.github.io/_site
 Incremental build: enabled
      Generating... 
       Jekyll Feed: Generating feed for posts
                    done in 0.178 seconds.
 Auto-regeneration: enabled for '~/Code/my_project/my_project.github.io'
    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.
[2023-05-02 14:29:25] ERROR `/vendor/font-awesome/css/font-awesome.min.css' not found.
[2023-05-02 14:29:25] ERROR `/vendor/bootstrap/css/bootstrap.min.css' not found.
[2023-05-02 14:29:25] ERROR `/vendor/jquery/jquery.min.js' not found.
[2023-05-02 14:29:25] ERROR `/vendor/bootstrap/js/bootstrap.min.js' not found.
[2023-05-02 14:29:25] ERROR `/favicon.ico' not found.
Kyomari commented 1 year ago

It seems that some of the vendor links are not resolving, which is causing the errors. It looks like you are using the Agency Jekyll theme, and some of the required CSS and JavaScript files are missing.

To fix this issue, make sure that the vendor directory is included in your site's root directory and contains the necessary files. You can download the missing files from the theme's GitHub repository and place them in the vendor directory.

Here are the files you should include:

vendor/bootstrap/css/bootstrap.min.css vendor/font-awesome/css/font-awesome.min.css vendor/jquery/jquery.min.js vendor/bootstrap/js/bootstrap.bundle.min.js Once you have added these files to your vendor directory, try running your Jekyll server again and see if the issue has been resolved. If you continue to have issues, double-check that the file paths in your HTML and CSS files match the file paths in your vendor directory.

byldhyre-dev commented 1 year ago

I manually included these files into my vendor directory by downloading the latest versions on the internet. Doing so resolved the vendor warnings but are now breaking for deprecation warnings, specifically TypeError: $(...).affix is not a function which I suspect is a bootstrap issue. I'm going to downgrade my libraries and see if it resolves that issue.

I'm confused though; given these libraries are included in source of this repository, why are they not packed with the gem and references as such?