search

yCodeTech / valet-windows

Laravel Valet for Windows.
https://packagist.org/packages/ycodetech/valet-windows
MIT License
27 stars 4 forks source link

PHP deprecated notice #6

Closed damsfx closed 4 months ago

damsfx commented 4 months ago

Description

PHP Deprecated: Optional parameter $site declared before required parameter $debug is implicitly treated as a required parameter

Steps To Reproduce

Fresh install of latest release (v3.0.0) with PHP 8.1.7

Diagnosis

PHP Deprecated:  Optional parameter $site declared before required parameter $debug is implicitly treated as a required parameter in C:\Users\damien\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php on line 774

Deprecated: Optional parameter $site declared before required parameter $debug is implicitly treated as a required parameter in C:\Users\damien\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php on line 774
PHP Deprecated:  Optional parameter $options declared before required parameter $debug is implicitly treated as a required parameter in C:\Users\damien\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php on line 774

Deprecated: Optional parameter $options declared before required parameter $debug is implicitly treated as a required parameter in C:\Users\damien\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php on line 774
PHP Deprecated:  Optional parameter $key declared before required parameter $follow is implicitly treated as a required parameter in C:\Users\damien\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php on line 1097

Deprecated: Optional parameter $key declared before required parameter $follow is implicitly treated as a required parameter in C:\Users\damien\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php on line 1097
yCodeTech commented 4 months ago

Can you describe how this error occurs please, as I can not replicate it on php 8.1.22

damsfx commented 4 months ago

Can you describe how this error occurs please, as I can not replicate it on php 8.1.22

This is just a fresh install over PHP v8.1.7.
You can read more about this notice here : https://php.watch/versions/8.0/deprecate-required-param-after-optional

You may not see the depreciated notice depending on your error_reporting setting.

yCodeTech commented 4 months ago

Ah ok, my PHP error_reporting setting was ignoring deprecation notices. After enabling all reports, I can see that the deprecation notice shows on any valet command. While it doesn't impact valet's functionality, I can see how this could raise problems in the future.