search

yDelouis / selfoss-android

Android application for Selfoss
MIT License
41 stars 9 forks source link

layout problems with leading image #25

Closed caksoylar closed 9 years ago

caksoylar commented 10 years ago

First of all, thanks for the new update! Syncing is now much faster with the new selfoss version, almost as fast as it was before image pre-loading.

However after the last update, there are problems in the article layout if the article has an image at top, see screenshot:

screenshot_2014-07-21-20-00-07

Other than the action bar and title text appearing on top of the image, the image is also horizontally clipped as its height is stretched.

yDelouis commented 10 years ago

It's made on purpose. In most cases the image isn't as important as the content and I tried to follow the material design guideline. You can still click the image to see it in a browser and long click it to see the title.

jonnyair commented 10 years ago

related to the image problem - would it be possible to outline the letters with a black line, so it shouldn't be a problem to read it, even if the background is white (similar to the font-color)?

caksoylar commented 10 years ago

I haven't actually checked the Material design guidelines, but one solution to make them visible on a light image might be to add gradients for the status bar and the title. For example Play Newsstand app puts a gradient on the status bar, and the title is below the image. Then I would argue the bottom outline of the status bar should also be removed.

Another solution might be a solid tint on the status bar (i.e. similar to the current one, but not full transparency), with a gradient on the title.

I will take a look at the Material guideline some time too, maybe there is a better solution than those above.