search

ySalaun / LineSfM

131 stars 46 forks source link

Some code seems useless #9

Closed JimZhou-001 closed 5 years ago

JimZhou-001 commented 5 years ago

Hello, @ySalaun!

Thank you for your great job on line-based SfM. I'm reading your code and have some doubts.

From line 246 to line 284 in LineSfM/CALIBRATION/scale_uniformization.cpp, you make a repartition among directions. But the code seems useless.

Firstly, variables dir_left, dir_right, proj_left, proj_right and found are defined in the function computeCoplanarCts. They are never used after line 284.

Secondly, though you modify cluster_left and cluster_right, which can be used beyond this function, the function computeCoplanarCts is only used once and these 2 parameters make no sense.

Maybe you wanted to do something, but you forgot?

And actually I don't know what this repartition do. Would you mind explaining it to me? Thank you.

Looking forward to your reply.

Sincerely, Jim

ySalaun commented 5 years ago

Hi,

I think that I wanted to do something and maybe I did some test. However, I cannot tell you what I wanted to do at this time and it would be better to delete it.

Thanks for the remark,

Yohann