search

yWorks / jsPDF

JavaScript PDF generation to work with SVG
MIT License
56 stars 23 forks source link

Update package.json (Fixes #10) #11

Closed zedtux closed 6 years ago

zedtux commented 6 years ago

Using HTTPS protocol instead of SSH in order to clone adler32cs and filesaver.js packages (Fixes #10)

zedtux commented 6 years ago

@HackbrettXXX any chance you have a look here please?

HackbrettXXX commented 6 years ago

I'm assuming you're just using jsPDF as a dependency and thus installing it via

npm install jspdf-yworks

If so, I have a suggestion for a different "fix": The dependencies listed in the "dependecies" entries should actually be "devDependencies" as they're only used during building and are bundled in the dist files. This way we could stick with the general "github" dependency and you're still able to install jsPDF with node < 1.1.65.

zedtux commented 6 years ago

Okay, well, this is quite old, and I don't really remember the issue I had in the past. There is another repo where I opened a very similar PR which has been merged, that's why I asked about this one.

As I'm no more working on this, I will close this PR so that you can do the change directly on master.