Update jspdf.js - Githubissues

yWorks / jsPDF

JavaScript PDF generation to work with SVG

MIT License

56 stars 23 forks source link

Update jspdf.js #15

Closed pYr0x closed 5 years ago

pYr0x commented 5 years ago

fix the issue where filename is not defined. close https://github.com/yWorks/jsPDF/issues/14

HackbrettXXX commented 5 years ago

I would prefer a solution like MrRio's:

if (typeof options === "string") {
  options = {
    filename: options
  };
} else {
  options.filename = options.filename || 'generated.pdf';
}

This has two advantages:

the diff to MrRio is smaller which makes merging easier
the user can still call pdf.output("save", "filename.pdf") with the filename as string (backwards compatibility)

yGuy commented 5 years ago

If this has already been fixed upstream, we should ideally rather do a new pull/reformat/merge, instead. If this is a serious regression and the merge is too complicated, feel free to "cherry pick" that change from upstream.

pYr0x commented 5 years ago

ok. do you know when a new version for yWorks/jsPDF will be available?

yGuy commented 5 years ago

We currently don't have the resources available until the end of the year. I will see whether I can find somebody to work on this. Sorry.

yGuy commented 5 years ago

Just a small update: We'll be doing a new round of implementations and fixes in the second half of January. Please stay tuned and sorry for the inconveniences caused.