fix unnecessary console warning for preexisting acroform classes

yWorks / jsPDF

JavaScript PDF generation to work with SVG

MIT License

56 stars 23 forks source link

fix unnecessary console warning for preexisting acroform classes #32

Closed sschmidTU closed 4 years ago

sschmidTU commented 4 years ago

... in global namespace

This solves #31 by eliminating the console warning. As discussed in #31, ultimately a wider solution of avoiding global namespace should be considered, but not having the console warning seems like an overall improvement for most cases right now.

fixes #31

HackbrettXXX commented 4 years ago

Thanks for the PR

sschmidTU commented 4 years ago

@HackbrettXXX Do you have a new npmjs release planned? It would be great to have one with this fix. But no pressure ;)

HackbrettXXX commented 4 years ago

There is a release planned, but I cannot tell you when I will find the time for that. I don't think it will be before early spring, though. We are currently busy with other stuff and I want to coordinate this release with svg2pdf 2.0.