search

yWorks / jsPDF

JavaScript PDF generation to work with SVG
MIT License
56 stars 23 forks source link

Enable the landscape orientation #4

Closed stefano-caporale-wk closed 5 years ago

stefano-caporale-wk commented 7 years ago

The commented portion of code allowed the landscape orientation (a feature that I and many users need). Without that code the landscape orientation is not possible. I suggest to leave it uncommented, it doesn't seem to me that it introduces bugs at all.

HackbrettXXX commented 7 years ago

I uncommented the code again. However, I moved it to _addPage() as beginPage() is also called by beginNewRenderTarget() and this might interfere with XObjects.

Could you check if this is working for you (orientation_pull_request)?

stefano-caporale-wk commented 7 years ago

Yes. It seems to me that now landscape orientation is working.

HackbrettXXX commented 7 years ago

Great! So I'm going to merge it into master.