search

yWorks / svg2pdf.js

A javascript-only SVG to PDF conversion utility that runs in the browser. Brought to you by yWorks - the diagramming experts
MIT License
654 stars 100 forks source link

Provide source map files or just remove the sourceMappingURL definition #125

Closed scribetw closed 4 years ago

scribetw commented 4 years ago

Is your feature request related to a problem? Please describe. When I open Chrome dev tool, Chrome will request an svg2pdf.js.map file since a sourceMappingURL comment is presented. But no source map is bundled with the js file.

Describe the solution you'd like Provide svg2pdf.js.map and svg2pdf.min.js.map in dist folder.

Describe alternatives you've considered Remove the source map definition in the js files

//# sourceMappingURL=svg2pdf.js.map

Additional context https://tracker.zkoss.org/browse/ZKCHARTS-104 our tracker

HackbrettXXX commented 4 years ago

Good point. We're probably going to fix this with the upcoming 2.0 release. We're currently quite occupied with other things, though, so this will take a while.

HackbrettXXX commented 4 years ago

Fixed with #119.