search

yWorks / svg2pdf.js

A javascript-only SVG to PDF conversion utility that runs in the browser. Brought to you by yWorks - the diagramming experts
MIT License
646 stars 96 forks source link

fix tSpan mispalsing on pdf #198

Closed inc198107 closed 1 year ago

HackbrettXXX commented 2 years ago

Some of the tests fail. Please check if that's just float imprecision or actual errors.

yGuy commented 2 years ago

Are you sure that removing that additional expression is always correct? What are your test-cases for the fix? Did you consider both the cases where the x and dx attributes are specified or not?

TBH this doesn't look like a clean pull-request at all. Also I guess you mean "misplaced" instead of "mispalsing"? Could you please edit the description and title?